Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide tx data overflow and allow line-wrap #785

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented Oct 18, 2023

Fixes #779

Description

Styling adjustments for tx payload data that is either a.) too long for one line or b.) goes vertically past the "expand" icon (downward chevron / arrow)

Test scenarios

Checked on both desktop and mobile

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 267760f
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/653047e2550104000874abf6
😎 Deploy Preview https://deploy-preview-785--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 267760f
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/653047e26a6071000867fdd7
😎 Deploy Preview https://deploy-preview-785--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 267760f
Status: ✅  Deploy successful!
Preview URL: https://640b1387.open-block-explorer.pages.dev
Branch Preview URL: https://779-tx-trace.open-block-explorer.pages.dev

View logs

Move tx data text wrap up a level

Adjustment to tx payload height

Remove junk code
@donnyquixotic donnyquixotic changed the base branch from master to develop October 18, 2023 22:29
@donnyquixotic donnyquixotic merged commit e146925 into develop Oct 18, 2023
10 checks passed
@donnyquixotic donnyquixotic deleted the 779-tx-trace branch October 18, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction Trace Details
2 participants