Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce header search input #814

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Debounce header search input #814

merged 5 commits into from
Dec 12, 2023

Conversation

kylanhurt
Copy link
Contributor

Fixes #813

Description

Added a debounce utility function and implemented it for header search

Test scenarios

Start typing into header

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 11d4ace
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/6578e8a6c1fff10008886b79
😎 Deploy Preview https://deploy-preview-814--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 11d4ace
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/6578e8a7d262410008eedc9d
😎 Deploy Preview https://deploy-preview-814--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6a7605a
Status: ✅  Deploy successful!
Preview URL: https://3b080898.open-block-explorer.pages.dev
Branch Preview URL: https://813-debounce-search.open-block-explorer.pages.dev

View logs

src/utils/time.ts Outdated Show resolved Hide resolved
src/components/HeaderSearch.vue Outdated Show resolved Hide resolved
@donnyquixotic donnyquixotic changed the base branch from master to develop December 12, 2023 23:11
@donnyquixotic donnyquixotic changed the base branch from develop to master December 12, 2023 23:12
@donnyquixotic donnyquixotic changed the base branch from master to develop December 12, 2023 23:14
@donnyquixotic donnyquixotic merged commit 7a0b02c into develop Dec 12, 2023
9 of 10 checks passed
@donnyquixotic donnyquixotic deleted the 813-debounce-search branch December 12, 2023 23:15
@donnyquixotic donnyquixotic mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need debounce for search to prevent incorrect results
2 participants