Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Upload #827

Merged
merged 1 commit into from
Jan 31, 2024
Merged

CSV Upload #827

merged 1 commit into from
Jan 31, 2024

Conversation

donnyquixotic
Copy link
Contributor

@donnyquixotic donnyquixotic commented Jan 30, 2024

Fixes #826

Description

see issue. useStore() was being called in an invalid scope within the csv upload component resulting in undefined store references.

Test scenarios

see issue

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

@donnyquixotic donnyquixotic self-assigned this Jan 30, 2024
Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 9f87581
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/65b98d61156627000891783f
😎 Deploy Preview https://deploy-preview-827--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 9f87581
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/65b98d61935863000816ef10
😎 Deploy Preview https://deploy-preview-827--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9f87581
Status: ✅  Deploy successful!
Preview URL: https://9d595625.open-block-explorer.pages.dev
Branch Preview URL: https://hotfix-csv-upload.open-block-explorer.pages.dev

View logs

@donnyquixotic donnyquixotic requested review from jbuice and removed request for jbuice January 31, 2024 00:00
@donnyquixotic donnyquixotic merged commit 3702702 into master Jan 31, 2024
10 checks passed
@donnyquixotic donnyquixotic deleted the hotfix/csv-upload branch January 31, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot upload CSV for batch transfer proposal
1 participant