Support externalDocs. Closes #112 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendo
force-pushed
the
feauture-112-external-docs-support
branch
from
b052d55
to
4d34d0b
Compare
brendo
force-pushed
the
feauture-112-external-docs-support
branch
from
4d34d0b
to
4523256
Compare
brendo
changed the title
quangkhoa
reviewed
Jul 15, 2017
| @@ -68,6 +76,21 @@ export default class Page extends Component { | |||
| ) | |||
| } | |||
|
|
|||
| findTagDocs (tagHandle, navigation) { | |||
There was a problem hiding this comment.
With this approach, the UI component is getting 'smart', as it is now understanding the relationship between services and navigation.
Another approach is to keep the UI component really simple, and handle externalDocs at the parser level.
What do you reckon @brendo ?
There was a problem hiding this comment.
As discussed, bit tricky, the parser is then making assumptions that the UI can't display tag information together (which we currently can't, as the tags form the navigation).
Secondly the parser is a bit hairy to make this possible right now :(
| @@ -230,7 +233,7 @@ function getUIParametersForLocation (parameters, location) { | |||
| function getUIRequest (description, requestBody = null) { | |||
| const uiRequest = {} | |||
|
|
|||
| if (description) { | |||
| if (description && description !== '') { | |||
There was a problem hiding this comment.
I thought an empty string would evaluate to false, as in https://developer.mozilla.org/en-US/docs/Glossary/Falsy?
quangkhoa
approved these changes
Jul 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to add some additional snapshot tests before merging.
Features:
externalDocsscenarios described in Add support for External Docs #112