-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace go.uber.org/atomic with sync/atomic #1344
Conversation
|
I always struggle with how to manage go.mod/go.sum changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always struggle with how to manage go.mod/go.sum changes
Yeah, our repo makes this a bit hard. Basically you need to run go mod tidy
in every directory that has a go.mod
in this repo.
This LGTM, will wait for @Quinn-With-Two-Ns to take a look
0961d80
to
c6dee57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have been meaning to do this anyway
go 1.19 introduced atomic types
c6dee57
to
4f580fd
Compare
Merged, thanks! |
What was changed
go 1.19 introduced atomic types
https://tip.golang.org/doc/go1.19#atomic_types
Why?
sync/atomic is already being used here. I intend to update dependencies so that
go.uber.org/atomic
can also be removed as an indirect dependency