Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace go.uber.org/atomic with sync/atomic #1344

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Jan 10, 2024

What was changed

go 1.19 introduced atomic types
https://tip.golang.org/doc/go1.19#atomic_types

Why?

sync/atomic is already being used here. I intend to update dependencies so that go.uber.org/atomic can also be removed as an indirect dependency

@serprex serprex requested a review from a team as a code owner January 10, 2024 19:29
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@serprex
Copy link
Contributor Author

serprex commented Jan 10, 2024

I always struggle with how to manage go.mod/go.sum changes

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always struggle with how to manage go.mod/go.sum changes

Yeah, our repo makes this a bit hard. Basically you need to run go mod tidy in every directory that has a go.mod in this repo.

This LGTM, will wait for @Quinn-With-Two-Ns to take a look

Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have been meaning to do this anyway

go 1.19 introduced atomic types
@cretz cretz merged commit 0f12265 into temporalio:master Jan 16, 2024
12 checks passed
@cretz
Copy link
Member

cretz commented Jan 16, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants