-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Review options for allowing protobuf 3.x to work with this library #181
Comments
open-telemetry/opentelemetry-python#2880 (comment) mentions that we may be able to just generate with proto 3.20+. Need to try this. |
This is complicated by the fact that we use https://pypi.org/project/grpcio-tools/ to generate our protobufs and the last version that supports proto 3.x (https://pypi.org/project/grpcio-tools/1.48.2/) doesn't have a Python 3.11 build. So code can't even be generated on latest Python when older proto library is in use. |
Applies to temporalio#181
Thanks a lot for working on this @cretz ! Do you have any idea on when this might be released? |
@schibrikov - I do not, but hopefully soon. Beta 4 should be released soon (but no exact date) |
Is your feature request related to a problem? Please describe.
Many libraries have not upgraded to 4.x while many have (including us). Depending on libraries that haven't is causing a problem for users. Most libraries seem to know they need to move to protobuf 4.x but just haven't done it.
Describe the solution you'd like
Consider options for supporting both. This could likely take the form of:
__all__
from the__init__
of the proto packages switch to importing the 3.x generated code if determined to be on 3.xThe text was updated successfully, but these errors were encountered: