Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timerMaxReadLevel map init and update #2498

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Fix timerMaxReadLevel map init and update #2498

merged 2 commits into from
Feb 14, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Feb 12, 2022

What changed?

  • When init, make sure for each cluster timer max read level is not before its ack level
  • For update, make sure the time max read level won't go backward (e.g due to time skew)

Why?

  • Fix bug, which may lead to timer task loss

How did you test it?
Added unit test

Potential risks

Is hotfix candidate?
yes

@yycptt yycptt requested review from yux0, wxing1292, yiminc and a team February 12, 2022 01:55
@yycptt yycptt closed this Feb 13, 2022
@yycptt yycptt reopened this Feb 13, 2022
@yycptt yycptt merged commit 27cc0b1 into temporalio:master Feb 14, 2022
@yycptt yycptt deleted the fix-timer-max-read-level branch February 14, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@yux0 yux0 yux0 approved these changes

@wxing1292 wxing1292 Awaiting requested review from wxing1292

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @yux0 @yiminc