Queue refactor part 6: shard context #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Feb 16, 2022
proto/internal/temporal/server/api/persistence/v1/executions.proto
Outdated
Show resolved
Hide resolved
yux0
reviewed
Feb 16, 2022
yiminc
reviewed
Feb 23, 2022
| } | ||
|
|
||
| func (s *ContextImpl) UpdateTransferAckLevel(ackLevel int64) error { | ||
| func (s *ContextImpl) updateScheduledTaskMaxReadLevel(cluster string) tasks.Key { |
There was a problem hiding this comment.
this name is a bit misleading. It is getting the timer queue's max read level based on current time.
There was a problem hiding this comment.
The method is kinda do two things. First update the max read level based on current time or remote cluster time, and then return the updated value. So I think the name does make sense to me. Any suggestion for a better name?
Comment on lines
+1011
to
+1018
| // TODO: | ||
| // 1. when deprecating old ack level related fields, use shardInfo.QueueAckLevels | ||
| // for calculating queue processing lag and diff. Current those old ack level fields | ||
| // are updated together with the new QueueAckLevels, so metrics can still be emitted | ||
| // correctly. | ||
| // 2. instead of having separate metric definition for each task category, we should | ||
| // use one metrics (or two, one for immedidate task, one for scheduled task), | ||
| // and add tags indicating the task category. |
There was a problem hiding this comment.
👍 please file an issue to track this.
yiminc
approved these changes
Feb 23, 2022
yux0
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Shard context change for queue processor refactor
Why?
How did you test it?
Existing tests
Potential risks
Is hotfix candidate?
no