Add service type tag to metrics #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardagan
force-pushed
the
AddServiceTypeTag
branch
2 times, most recently
from
c8bd09a to
4068ec3
Compare
yiminc
approved these changes
Feb 25, 2022
Ardagan
force-pushed
the
AddServiceTypeTag
branch
from
4068ec3 to
e7b14cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added service type tag to metrics.
Why?
Easier debugging
How did you test it?
manual/unit tests
Potential risks
Metrics are not reported correctly.
Dashboards might not handle new tag correctly.
Is hotfix candidate?
No