Adding heartbeat details in RespondActivityTaskFailed apis #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Mar 2, 2022
yiminc
approved these changes
Mar 4, 2022
yiminc
reviewed
Mar 4, 2022
yycptt
reviewed
Mar 4, 2022
yycptt
reviewed
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add optional heartbeat details to RespondActivityFailed apis
Why?
Convenience for SDK to flush/combine heartbeat and failure into a single API call.
#2443
Intentionally if the heartbeat details blob violates size constraints the same activity failure would be recorded as if the API calls where separate.
How did you test it?
Local tests
Potential risks
None
Is hotfix candidate?
No