Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence Context Part 1: Execution Manager #2622

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Persistence Context Part 1: Execution Manager #2622

merged 3 commits into from
Mar 21, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 18, 2022

What changed?

  • Add context parameter to execution manger interface
  • Passed in context is not used right now
  • Wire up most logic in application layer to pass context parameter to persistence
  • Some application logic still use context.TODO() as placeholder and will be replace later.

Why?

  • Enforce persistence timeout, instead of always timeout after 10s
  • Require for host level task worker pool

How did you test it?

  • Existing tests

Potential risks
N/A

Is hotfix candidate?
no

@yycptt yycptt requested a review from a team as a code owner March 18, 2022 23:38
@yycptt yycptt force-pushed the persistence-context branch from 3fb183a to b83cc50 Compare March 18, 2022 23:51
@yycptt yycptt merged commit f4c0852 into temporalio:master Mar 21, 2022
@yycptt yycptt deleted the persistence-context branch March 21, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@wxing1292 wxing1292 wxing1292 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @wxing1292 @yiminc