Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence Context Part 2: Shard, Task, Metadata, ClusterMetadata Manager #2632

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 22, 2022

What changed?

  • Add context parameter to Shard, Task, Metadata, ClusterMetadata manager interface
  • Passed in context is not used right now
  • Wire up most logic in application layer to pass context parameter to persistence
  • Some application logic still use context.TODO() as placeholder and will be replace later.

Why?

  • Enforce persistence timeout, instead of always timeout after 10s
  • Require for host level task worker pool

How did you test it?

  • Existing tests

Potential risks

  • Very low risk as passed in context not used

Is hotfix candidate?
no

@yycptt yycptt requested a review from yiminc March 22, 2022 20:17
@yycptt yycptt requested a review from a team as a code owner March 22, 2022 20:17
common/membership/rpMonitor.go Outdated Show resolved Hide resolved
@yycptt yycptt merged commit a0c9001 into temporalio:master Mar 23, 2022
@yycptt yycptt deleted the persistence-context branch March 23, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants