Persistence context part 5: persistence store interfaces #2659

yycptt · 2022-03-28T18:54:59Z

What changed?

Add context parameter to persistence store interfaces.
NOTE: there's no behavior change in this PR. SQL and Cassandra store implementation still ignores the context passed it. Those will be changed in a follow up PR.

Why?

Enforce persistence timeout, instead of always timeout after 10s
Required for host level task worker pool

How did you test it?

Existing test

Potential risks

Very low, context is currently ignored by persistence store implementation

Is hotfix candidate?

No.

yycptt · 2022-03-28T18:56:02Z

common/persistence/sql/cluster_metadata.go

@@ -44,6 +45,7 @@ type sqlClusterMetadataManager struct {
 var _ p.ClusterMetadataStore = (*sqlClusterMetadataManager)(nil)

 func (s *sqlClusterMetadataManager) ListClusterMetadata(
+	_ context.Context,
 	request *p.InternalListClusterMetadataRequest,
 ) (*p.InternalListClusterMetadataResponse, error) {
 	ctx, cancel := newExecutionContext()


This PR does not include any behavior change.
newExecutionContext will be removed in a follow up PR for actually using the passed in context.

Persistence context part 5: persistence store interfaces

6d3d3a1

yycptt requested a review from a team as a code owner March 28, 2022 18:55

yycptt commented Mar 28, 2022

View reviewed changes

wxing1292 approved these changes Mar 28, 2022

View reviewed changes

yycptt merged commit d6f85df into temporalio:master Mar 28, 2022

yycptt deleted the persistence-ctx-store branch March 28, 2022 22:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Persistence context part 5: persistence store interfaces #2659

Persistence context part 5: persistence store interfaces #2659

yycptt commented Mar 28, 2022

yycptt Mar 28, 2022

Persistence context part 5: persistence store interfaces #2659

Persistence context part 5: persistence store interfaces #2659

Conversation

yycptt commented Mar 28, 2022

yycptt Mar 28, 2022

Choose a reason for hiding this comment