Add validation for a few string fields #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
force-pushed
the
validate_utf8_string
branch
from
fa92899 to
e0e373e
Compare
yycptt
reviewed
Mar 5, 2024
yycptt
approved these changes
Mar 5, 2024
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 5, 2024
## What changed? Add string validation for a few string fields ## Why? Since we disable utf8 string validation from proto level, we want to enforce minimal validation for some key fields. ## How did you test it? Unit tests ## Potential risks No ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
stephanos
pushed a commit
to stephanos/temporal
that referenced
this pull request
Mar 21, 2024
## What changed? Add string validation for a few string fields ## Why? Since we disable utf8 string validation from proto level, we want to enforce minimal validation for some key fields. ## How did you test it? Unit tests ## Potential risks No ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 28, 2024
Add string validation for a few string fields Since we disable utf8 string validation from proto level, we want to enforce minimal validation for some key fields. Unit tests No <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 28, 2024
Add string validation for a few string fields Since we disable utf8 string validation from proto level, we want to enforce minimal validation for some key fields. Unit tests No <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 28, 2024
Add string validation for a few string fields Since we disable utf8 string validation from proto level, we want to enforce minimal validation for some key fields. Unit tests No <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add string validation for a few string fields
Why?
Since we disable utf8 string validation from proto level, we want to enforce minimal validation for some key fields.
How did you test it?
Unit tests
Potential risks
No
Documentation
Is hotfix candidate?