Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring UI public path #211

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Support configuring UI public path #211

merged 2 commits into from
Sep 9, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Sep 6, 2022

What was changed

Allows serving UI under subpaths, ex http://localhost:8080/subpath1/namespaces

Why?

partially resolve temporalio/ui#576

Checklist

  1. Closes

  2. How was this tested:

Started and verified ui-server with publicPath: /custom-path set in development.yml

Does not yet work with docker images. TBU #213

  1. Any docs updates needed?

@feedmeapples feedmeapples marked this pull request as draft September 6, 2022 00:24
@feedmeapples feedmeapples force-pushed the public-path branch 2 times, most recently from c4084ca to cb18f17 Compare September 7, 2022 05:16
@feedmeapples feedmeapples marked this pull request as ready for review September 7, 2022 05:16
@feedmeapples feedmeapples changed the title Allow changing UI & API public path Support configuring UI public path Sep 9, 2022
@feedmeapples feedmeapples removed the request for review from stevekinney September 9, 2022 03:37
@feedmeapples feedmeapples merged commit 157ba50 into main Sep 9, 2022
@feedmeapples feedmeapples deleted the public-path branch September 9, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support serving UI under subpaths
2 participants