Refactor Versioning apis and UIs #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
approved these changes
May 9, 2024
| $: ({ queue: taskQueue, namespace } = $page.params); | ||
| </script> | ||
|
|
||
| {#await getPollers({ queue: taskQueue, namespace }) then workers} |
There was a problem hiding this comment.
Only thought is if we want some kind of loading state here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This simplifies how we fetch and display versioning info. Now only the /workers and /task-queues/{queue} pages will fetch the versioning rules and compatibility. If either or both fail, show WorkerTable.
/workerswill check if the workflow is using versioning before fetching the rules and compatibilities./task-queues/{queue}will fetch both always.Both the rules and compatibility apis will swallow any errors and return undefined if they fail.
The Workflow Header will only show current BuildId of the workflow if using versioning.
NOTE: Rules api will always fail right now in OSS.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?