Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs to nav #2131

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Add docs to nav #2131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45359cb
add docs to side nav
GraceGardner May 31, 2024
56e0b47
merge main
GraceGardner May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lib/components/side-nav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@
label={translate('common.namespaces')}
icon="namespace"
/>
<NavigationItem
link={linkList.docs}
data-testid="docs-button"
label={translate('common.docs')}
icon="book"
/>
</IsLegacyCloudGuard>
<slot name="middle" />
</svelte:fragment>
Expand Down
3 changes: 2 additions & 1 deletion src/lib/holocene/icon/paths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import arrowUp from './svg/arrow-up.svelte';
import ascending from './svg/ascending.svelte';
import astronaut from './svg/astronaut.svelte';
import batchOperation from './svg/batch-operation.svelte';
import book from './svg/book.svelte';
import book from './svg/book-sparkles.svelte';
// import book from './svg/book.svelte';
import bookmark from './svg/bookmark.svelte';
import calendarPlus from './svg/calendar-plus.svelte';
import calendar from './svg/calendar.svelte';
Expand Down
1 change: 1 addition & 0 deletions src/lib/i18n/locales/en/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,5 @@ export const Strings = {
'execution-details': 'Execution Details',
day: 'Day',
night: 'Night',
docs: 'Docs',
} as const;
1 change: 1 addition & 0 deletions src/routes/(app)/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
feedback:
$page.data?.settings?.feedbackURL ||
'https://github.com/temporalio/ui/issues/new/choose',
docs: 'http://docs.temporal.io',
};

function getCurrentHref(namespace: string) {
Expand Down
Loading