Fix api pagination alignment, add debounce as a prop #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
approved these changes
Jun 4, 2024
Alex-Tideman
pushed a commit
that referenced
this pull request
Jun 6, 2024
* fix alignment of api pagination slots * fix * fix slot check * add debounce as a prop * spelling * fix debounce * remove loading slot prop
Alex-Tideman
added a commit
that referenced
this pull request
Jun 6, 2024
* Add config and command to run local temporal server, remove versioning on workflow worker tab, add link to task queue, add tabs for workers/versioning on task queue page. Add view all assignment rules row * send resetType in request body for batch reset (#2110) * send resetType in req body for batch reset for compatibility with older server/api versions * default reset type to first, clear up reason hint text * 2.27.4 (#2111) Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> * remove import from protos, use custom enum (#2112) * 2.27.5 (#2113) Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> * Remove copyable tooltip (#2114) * Fix issue where close button cannot be seen on dark drawers (#2115) * Fix issue where close button cannot be seen on dark drawers * Update drawer.stories.svelte * Update drawer.stories.svelte * DT-2159 - fix "Reapply Signals" checkbox on reset workflow confirmation form (#2117) * use binding instead of on:change for reset reapply checkbox * add regression integration test * Night mode audit (#2118) * Update and consolidate surface colors * Update text colors * Update border colors * Update shadow colors * Remove unnecessary colors * Fix box shadow color * Use ring instead of box shadow * Update WorkflowStatus colors * Fix simple TableHeaderRow * Input updates based on designs * Fix table headers and various text and bg colors * Update button styles to match designs * Remove disabled color variables, update placeholder text and update Pill component * Update checkbox and radio input * Update toggle switch * Update IconButton to use Button component * Remove unnecessary badge background * Update Toast component colors * Update snaps and fix errors * Remove unnecessary surface-input * Update page background color to match designs * Update timeline background and text color * Remove underline on button links * Remove ternary and use and instead for active class * Delete snapshot tests * Kebab case colors * Keep Button border as 2px on focus * Add caret-danger to plugin * 2.27.6 (#2122) Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> * Add local-temporal command (#2120) * Update SideNavigation component (#2124) * Update side nav focus styles * Update heart beat indicator color * Update version.go to v2.27.2 (#2126) * Link to namespace in Namespace sticky nav (#2123) * Add href prop to combobox for link button * Subtle border, better path, disable link if no namespace * add docs to side nav (#2131) * add filtering to api pagination (#2130) * DT-2179 - fix wf reset button & other fixes (#2133) * missed PR feedback - fix ApiPagination prop typing and name - add search icon to input in ApiPagination * fix workflow reset button disabled logic * move docs link * use cloud guard * Add timezoneName to schedule spec with default of UTC (#2127) * Add timezoneName to schedule spec with default of UTC * Use translate for timezones * Set input on edit * Add onDecode prop * 2.27.7 (#2134) Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> * Audit a11y issues (#2135) * DT-2134 Fix a11y issues with accordion.svelte * Remove on:keydown on CodeBlock I could not find a single use of `CodeBlock` that had an on:keydown event. [Related ticket](https://temporalio.atlassian.net/browse/DT-2135). * Update filter-or-copy-buttons.svelte These both appear to be `noop` functions? * clean up workflow actions (#2136) * clean up workflow actions * better i18n string name * fix batch action checks * fix tests * add integration tests * 2.27.8 (#2137) Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> * Update workflow status colors (#2132) * Update running color * Update scheduled color * Update completed and open color * Update new and initiated color * Use globalThis.accessToken() for codec server calls (#2138) * Fix api pagination alignment, add debounce as a prop (#2139) * fix alignment of api pagination slots * fix * fix slot check * add debounce as a prop * spelling * fix debounce * remove loading slot prop * 2.27.9 (#2140) Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> * Fix header colors * Update snaps? * Remove commented out mock, better check for rules * Remove dup .env --------- Co-authored-by: Ross Edfort <rossedfort@gmail.com> Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> Co-authored-by: Steve Kinney <hello@stevekinney.net> Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io> Co-authored-by: Grace Iris Gardner <42048868+GraceGardner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
diveven if slot content wasn't provided, and relying onjustify-betweento shift the page controls to the end of the flex box. In add filtering to api pagination #2130 added a check to only render the div if the slot is provided, and that broke the alignment of the page controls. This removes the check for the presence of the action-top-left slot, but also removes the wrappingdiv, and conditionally adds a justify-end class based on the presence of this slot. I checked all places we supply the action-top-left slot and it still looks fine.Screenshots (if applicable) 📸
before
after (without filter)
after (with filter)
after (with action-top-left slot)
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?