Filter search a11y updates #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
commented
Jun 7, 2024
| @@ -40,6 +41,7 @@ | |||
| export let href = null; | |||
| export let description: string = null; | |||
| export let centered = false; | |||
| export let hover = true; | |||
There was a problem hiding this comment.
Not sure about calling this hover, so open to feedback here. Just want some way of making the hover styling here optional.
There was a problem hiding this comment.
Yeah that's slightly better, updated ✔️
Alex-Tideman
approved these changes
Jun 11, 2024
laurakwhit
force-pushed
the
DT-2136-a11y-updates-filter-search
branch
from
34130a1 to
502d404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2136Docs
Any docs updates needed?