Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateMultipleQueryParameters #2156

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

Add util updateMultipleQueryParameters with ability to update multiple query params at once.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:49pm

clearParameters?: string[];
};

export const updateMultipleQueryParameters = async ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we combine this and updateQueryParameters at some point? But didn't want to touch existing logic with this PR.

@laurakwhit laurakwhit merged commit 46f456a into main Jun 12, 2024
10 checks passed
@laurakwhit laurakwhit deleted the update-multiple-query-params branch June 12, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants