Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling improvements for Nexus #2224

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Error handling improvements for Nexus #2224

merged 1 commit into from
Jul 22, 2024

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Jul 22, 2024

Description & motivation 💭

  • Return 404 page for endpoint not found instead of 500 error
  • Use endpoint name on delete confirmation modal and remove need to type DELETE before the name

Screenshots (if applicable) 📸

Screenshot 2024-07-22 at 8 36 48 AM Screenshot 2024-07-22 at 8 36 58 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

…onfirmation and remove the need to type DELETE.
@Alex-Tideman Alex-Tideman requested review from stevekinney and a team as code owners July 22, 2024 13:39
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:39pm

@Alex-Tideman Alex-Tideman merged commit a205f52 into main Jul 22, 2024
11 checks passed
@Alex-Tideman Alex-Tideman deleted the nexus-404-catch branch July 22, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants