Dispatch ChangeSet instead of creating new EditorState on resetView in CodeBlock component #2243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
We're seeing the occasional
RangeError: Invalid change range [num] to [num] (in doc of length [num])
error coming from@codemirror
and it looks like it's happening forCodeblock
s inModal
components. Specifically after this is called ⬇️ui/src/lib/components/workflow/client-actions/signal-confirmation-modal.svelte
Line 28 in 50a5e10
This PR dispatches a transaction with a
ChangeSet
inresetView
on theCodeBlock
component instead of creating a whole newEditorState
and callingsetState
.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Running
workflowSend a Signal
> fill outName
andInput
> close the modalSend a Signal
againInput
has been clearedName
> tab toInput
and fill out (this is where error was occurring)Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?