Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and edit responsive improvements #2457

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

Makes action buttons full width and stacked on small screens.

Before After
Screenshot 2024-12-04 at 2 12 37 PM Screenshot 2024-12-04 at 2 16 28 PM
Screenshot 2024-12-04 at 2 33 16 PM Screenshot 2024-12-04 at 2 17 59 PM
Screenshot 2024-12-04 at 2 18 42 PM Screenshot 2024-12-04 at 2 19 29 PM
Screenshot 2024-12-04 at 2 20 06 PM Screenshot 2024-12-04 at 2 23 10 PM
Screenshot 2024-12-04 at 2 26 13 PM Screenshot 2024-12-04 at 2 29 15 PM

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  • Verify the action buttons (e.g. Create, Save, Delete, Cancel) show up and work as expected on large and small screens for the following pages
    • /schedules/create
    • /schedules/[schedule]/edit
    • /nexus/create
    • /nexus/[endpoint]/create
    • /workflows/start-workflow

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from rossedfort and a team as code owners December 4, 2024 21:35
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 9:35pm

@laurakwhit laurakwhit merged commit 7447294 into main Dec 5, 2024
14 checks passed
@laurakwhit laurakwhit deleted the create-and-edit-responsive-improvements branch December 5, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants