Allow configuration of global policy config, fix some typos #354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 61.42% 61.62% +0.19%
==========================================
Files 72 73 +1
Lines 1602 1639 +37
==========================================
+ Hits 984 1010 +26
- Misses 532 539 +7
- Partials 86 90 +4
|
There was a problem hiding this comment.
Hi @acc-jon,
We already have a config file in terrascan. You can check the sample config file at https://github.com/accurics/terrascan/blob/master/config/terrascan.toml.
We have adopted the toml format for config file, as it is intuitive, easy to use and read.
I see that you expect the Global config file indicated by TERRASCAN_CONFIG to be a json file. This creates two types of config files within terrascan.
Hence, I would request you revise this once again.
|
Kudos, SonarCloud Quality Gate passed!
|
| // check if file exists | ||
| _, err := os.Stat(configFile) | ||
| if err != nil { | ||
| zap.S().Errorf("Can't find '%s'", configFile) |
There was a problem hiding this comment.
Small suggestion to not have error strings capitalized: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
No description provided.