rule skipping for resources in k8s #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 74.11% 74.69% +0.57%
==========================================
Files 87 88 +1
Lines 2013 2039 +26
==========================================
+ Hits 1492 1523 +31
+ Misses 388 382 -6
- Partials 133 134 +1
|
2. remove default command code
…rror Fix exit code on error
…urce config comments
williepaul
reviewed
Jan 8, 2021
|
|
||
| func readSkipRulesFromAnnotations(annotations map[string]interface{}, resourceID string) []string { | ||
|
|
||
| if _, ok := annotations[terrascanSkipRules]; !ok { |
There was a problem hiding this comment.
Can you remove the assignment on 148 and just specify skipRulesFromAnnotations in place of _ here?
Add support to extract rules to skip from terraform comments
2. fix typos in test name
|
Kudos, SonarCloud Quality Gate passed!
|
williepaul
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.