refactor init command for robust policy download checks #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 75.32% 75.34% +0.02%
==========================================
Files 94 94
Lines 2233 2235 +2
==========================================
+ Hits 1682 1684 +2
Misses 408 408
Partials 143 143
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we delete the existing locally cached policy set before making ensuring that the new policy set can be download ( there can be absence of internet connection or maybe github servers down leading to disability in downloading new policy set).
This PR will refactor the init process so that we download the new policy set before sweeping off the existing locally cached policy set.