Allow sphero gem to optionally use rs232 gem for serial communication #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, your sphero library is great but I could not get it working on Windows using the serialport gem. I was able to get it working with the rs232 gem after I made a patch (that patch has already been merged). If you are interested I tried to make the sphero library configurable about which gem to use for serial port communication. If you set the environment variable RUBY_SPHERO_RS232 it will use rs232, otherwise it will use serialport. Let me know if you're interested in these changes and if there are any changes you'd like me to make first.
Thanks again,
Dan