Skip to content
This repository has been archived by the owner on Jul 15, 2018. It is now read-only.

Add InitialValSet and AppHash to ResponseInitChain #220

Closed
wants to merge 2 commits into from

Conversation

adrianbrink
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 27, 2018

Codecov Report

Merging #220 into develop will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #220      +/-   ##
===========================================
- Coverage    14.69%   14.62%   -0.08%     
===========================================
  Files           15       15              
  Lines         2361     2373      +12     
===========================================
  Hits           347      347              
- Misses        1984     1996      +12     
  Partials        30       30
Impacted Files Coverage Δ
types/types.pb.go 4.84% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62aed9...dfc0e27. Read the comment docs.

@melekes
Copy link
Contributor

melekes commented Mar 27, 2018

You forgot to regenerate types/types.pb.go (make get_protoc && make protoc)

@ebuchman
Copy link
Contributor

Let's put the entire Genesis structure in protobuf and include that?

#216

@adrianbrink
Copy link
Contributor Author

I don't think we need the entire genesis.json structure. What's the advantage of including everything?

@melekes
Copy link
Contributor

melekes commented Mar 28, 2018

Refs tendermint/tendermint#1271

@adrianbrink adrianbrink deleted the adrian/genesis_staking branch May 13, 2018 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants