Skip to content
This repository has been archived by the owner on Jul 15, 2018. It is now read-only.

Change AppStateBytes to GenesisBytes #234

Merged
merged 3 commits into from
May 14, 2018
Merged

Conversation

adrianbrink
Copy link
Contributor

@adrianbrink adrianbrink commented May 13, 2018

The consensus should pass the entire genesis file to the application.
That way the application has access to the chain_id, the timestap, ...

depends #233
closes #216

The consensus should pass the entire genesis file to the application.
That way the application has access to the chain_id, the timestap, ...
@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #234 into develop will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #234   +/-   ##
========================================
  Coverage    14.67%   14.67%           
========================================
  Files           15       15           
  Lines         2365     2365           
========================================
  Hits           347      347           
  Misses        1988     1988           
  Partials        30       30
Impacted Files Coverage Δ
types/types.pb.go 4.88% <0%> (ø) ⬆️
example/dummy/helpers.go 100% <100%> (ø) ⬆️
example/kvstore/helpers.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49849de...063a7d8. Read the comment docs.

@ebuchman ebuchman changed the base branch from adrian/requestinitchain to develop May 14, 2018 22:24
@ebuchman ebuchman merged commit 453e8ef into develop May 14, 2018
@ebuchman ebuchman deleted the adrian/genesis_bytes branch May 14, 2018 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants