docs: add -i options for sed considering os #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybxyz
reviewed
Oct 28, 2021
jaybxyz
approved these changes
Nov 1, 2021
jaybxyz
added a commit
to jaybxyz/budget
that referenced
this pull request
Nov 3, 2021
* main: docs: add -i options for sed considering os (tendermint#68) fix: Add govHandler on testcode for budget proposal and Fix Expired rule (tendermint#66) fix: panic instead of ignoring errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses FreeBSD sed command (which is default for MacOS) but I have installed gnu
sedcommand (which is default for linux distros) and due to this reason the sed commands from the script can't be workso need to add simple os checking and using different
-ioptions for each osReferences
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes