Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation totalRate to check date overlapped budgets #83

Merged

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Nov 3, 2021

Description

closes: #82

Tasks

  • refactor CollectibleBudgets, MustParseRFC3339
  • modify budget validation
  • add testcase for the validation
  • remove duplicated validating logic (suggested on this)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam marked this pull request as ready for review November 3, 2021 11:02
x/budget/types/utils_test.go Outdated Show resolved Hide resolved
x/budget/keeper/budget.go Outdated Show resolved Hide resolved
@dongsam dongsam mentioned this pull request Nov 5, 2021
9 tasks
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam merged commit e20df59 into tendermint:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix validation totalRate to check date overlapped budgets
2 participants