fix: rename some fields of Budget #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `BudgetSourceAddress` to `SourceAddress` - `CollectionAddress` to `DestinationAddress`
Co-authored-by: JayB <jaybkim2@gmail.com>
…-names-2 * commit 'e20df5916e12a7b8456ecfcf18db7f2dc1cc4753': fix: budget end time should be after budget start time fix: remove duplicated validating logic test: add more tests for `DateRangesOverlap` chore: refactor missed part fix: refactor CollectibleBudgets and add test cases fix: capture variables in a loop for the deferred func fix: update validation logic and refactor mustParseRFC3339 and add testcase fix: add overlap checking on budget validation feat: apply from the suggestion refactor: order import fix: refactor collectible budgets function feat: add telemetry metrics build: add go-metrics for telemetry feat: need more tests feat: adding metrics is work in progress # Conflicts: # x/budget/keeper/budget_test.go # x/budget/keeper/grpc_query_test.go # x/budget/keeper/keeper_test.go # x/budget/simulation/genesis.go # x/budget/types/params.go # x/budget/types/params_test.go
dongsam
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
@hallazzang I just merged with upstream and resolved the conflicts
jaybxyz
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #80
Reference
#84
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes