-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: edit farming spec SEE INSTEAD https://github.com/tendermint/farming/pull/191 #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions related to my edits, please see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for you contribution @barriebyron . I can see there's a lot of improvements! Sentences are a lot more smoother now and they are consistent throughout the docs.
Regarding the questions you have, I left my replies below. Please let me know if you have any more questions and re-request my review when you think it is ready to be merged.
@kogisin small update to clarify no fee for public plan. |
UH OH, I meant to checkout the original files from master to create-codeowners however, I accidentally got back the original files in this PR (where is the shaking my head emoji when I need it?) @kogisin can you help me restore this PR back to this commit: 4d2bdf4 right now, I've undone my changes (eeeekkkk!!) help |
#191 is the new place that I didn't screw up yet! |
Description
edit farming spec to improve documentation quality #172
Tasks
part of #172
References
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes