Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: edit farming spec SEE INSTEAD https://github.com/tendermint/farming/pull/191 #188

Closed
wants to merge 12 commits into from

Conversation

barriebyron
Copy link
Contributor

Description

edit farming spec to improve documentation quality #172

Tasks

part of #172

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@barriebyron barriebyron self-assigned this Oct 21, 2021
Copy link
Contributor Author

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions related to my edits, please see

x/farming/spec/01_concepts.md Outdated Show resolved Hide resolved
x/farming/spec/01_concepts.md Outdated Show resolved Hide resolved
x/farming/spec/01_concepts.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for you contribution @barriebyron . I can see there's a lot of improvements! Sentences are a lot more smoother now and they are consistent throughout the docs.

Regarding the questions you have, I left my replies below. Please let me know if you have any more questions and re-request my review when you think it is ready to be merged.

@barriebyron
Copy link
Contributor Author

@kogisin small update to clarify no fee for public plan.
I think we are ready to merge?

@barriebyron
Copy link
Contributor Author

UH OH, I meant to checkout the original files from master to create-codeowners
to remediate the unintended changes in #189

however, I accidentally got back the original files in this PR (where is the shaking my head emoji when I need it?)

@kogisin can you help me restore this PR back to this commit: 4d2bdf4

right now, I've undone my changes (eeeekkkk!!) help

@barriebyron
Copy link
Contributor Author

#191 is the new place that I didn't screw up yet!

@barriebyron barriebyron changed the title docs: edit farming spec to improve documentation quality #172 docs: edit farming spec SEE INSTEAD https://github.com/tendermint/farming/pull/191 Oct 25, 2021
@barriebyron barriebyron deleted the edit-farming-spec branch October 25, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants