Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create CODEOWNERS file and update contributing.md #189

Merged
merged 3 commits into from
Oct 26, 2021
Merged

feat: Create CODEOWNERS file and update contributing.md #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc0f4d0
create CODEOWNERS file
Oct 22, 2021
9a2eb0c
move codeowners from contributing file to the CODEOWNERS file
Oct 22, 2021
eda26da
Merge branch 'main' into create-codeowners
dongsam Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# CODEOWNERS: https://help.github.com/articles/about-codeowners/

# Docs
*.md @barriebyron

# Primary repo maintainers
* @dongsam @kogisin @hallazzang
15 changes: 9 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
# Contributing

We welcome contributions from anyone who is willing to create a new PR on farming module, make sure that you read and comply with this document. See the [open issues](https://github.com/tendermint/farming/issues) that we need help with. Feel free to inform us if you are willing to work on any issue. Note that the `main` branch contains the latest development version.
We welcome contributions to our codebase and documentation.

We follow standard github best practices:
Before you create a PR on the farming module, make sure that you read and comply with this document. See the [open issues](https://github.com/tendermint/farming/issues) that we need help with.

Feel free to inform us if you are willing to work on an issue. Note that the `main` branch contains the latest development version.

We follow standard GitHub best practices:

- Fork the repository
- Make sure your `branch` is from the tip of `main` branch
- Make some commits to resolve an issue
- Make your commits to resolve an issue
- Submit a pull request to `main`

Rule of thumb:
General guidance:

- Make sure you run tests by running `make test-all` locally to see there is any issue
- Review all the checks on your PR and review code coverage report
- Assign reviewers from code owners (@dongsam @kogisin @hallazzang)
- Review all the checks on your PR and review the code coverage report

Thank you for your contribution!