Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split staking reserve acc by staking denom #229

Merged

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Nov 16, 2021

Description

closes: #220

Tasks

  • Add AddressType, DeriveAddress
  • Refactor StakingReservePoolAcc, to using DeriveAddress and StakingCoinDenom
  • Add TotalStakingsRecords
  • Update Invariant for TotalStakingsAmount
  • Deprecate global StakingReserveAcc
  • Set default ReserveAddressType
  • Add testcases
  • Refactor relevant functions
  • Resolve in-line todo list
  • Update docs and spec

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam changed the title fix: split reserve acc by staking denom fix: split staking reserve acc by staking denom Nov 16, 2021
@dongsam dongsam marked this pull request as ready for review November 18, 2021 19:09
proto/tendermint/farming/v1beta1/genesis.proto Outdated Show resolved Hide resolved
proto/tendermint/farming/v1beta1/genesis.proto Outdated Show resolved Hide resolved
x/farming/spec/01_concepts.md Outdated Show resolved Hide resolved
x/farming/spec/03_state_transitions.md Outdated Show resolved Hide resolved
x/farming/spec/04_messages.md Outdated Show resolved Hide resolved
x/farming/spec/04_messages.md Outdated Show resolved Hide resolved
x/farming/types/plan.go Outdated Show resolved Hide resolved
x/farming/types/params.go Outdated Show resolved Hide resolved
x/farming/spec/01_concepts.md Outdated Show resolved Hide resolved
x/farming/spec/04_messages.md Outdated Show resolved Hide resolved
x/farming/spec/04_messages.md Outdated Show resolved Hide resolved
x/farming/types/params.go Outdated Show resolved Hide resolved
x/farming/types/utils.go Outdated Show resolved Hide resolved
@dongsam dongsam merged commit 064f180 into tendermint:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up reserve accounts per staking coin denom
3 participants