Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defers from getTypeInfo functions #227

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Remove defers from getTypeInfo functions #227

merged 2 commits into from
Oct 15, 2018

Commits on Sep 18, 2018

  1. Remove defers from getTypeInfo functions 

    These defers were taking up 1% of the gaia state machines time,
due to their usage within MarshalJSON and UnmarshalBinaryBare.

There is no safety concern for removing these defers, as none of
the methods within the functions should panic.
    @ValarDragon
    ValarDragon committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    866c0d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2018

  1. Add comments for defer removal

    @ValarDragon
    ValarDragon committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    ec53ca6 View commit details
    Browse the repository at this point in the history