feat(profile): events (#742)

* add proto * compile proto * emit events * emit proper events * fix error Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
tendermint · Apr 25, 2022 · 424657d · 424657d
1 parent 10f3301
commit 424657d
Show file tree

Hide file tree

Showing 8 changed files with 914 additions and 12 deletions.
diff --git a/proto/profile/events.proto b/proto/profile/events.proto
@@ -0,0 +1,25 @@
+syntax = "proto3";
+package tendermint.spn.profile;
+
+import "gogoproto/gogo.proto";
+import "profile/coordinator.proto";
+import "profile/validator.proto";
+
+
+option go_package = "github.com/tendermint/spn/x/profile/types";
+
+message EventCoordinatorCreated {
+  Coordinator coordinator = 1 [(gogoproto.nullable) = false];
+}
+
+message EventCoordinatorUpdated {
+  Coordinator coordinator = 1 [(gogoproto.nullable) = false];
+}
+
+message EventValidatorCreated {
+  Validator validator = 1 [(gogoproto.nullable) = false];
+}
+
+message EventValidatorUpdated {
+  Validator validator = 1 [(gogoproto.nullable) = false];
+}
diff --git a/x/profile/keeper/msg_add_validator_operator_address.go b/x/profile/keeper/msg_add_validator_operator_address.go
@@ -22,8 +22,9 @@ func (k msgServer) AddValidatorOperatorAddress(
 		Description:       types.ValidatorDescription{},
 	}
 
-	// get the current validator to eventually overwrite description and remove existing operator address
-	if validatorStore, found := k.GetValidator(ctx, valAddr); found {
+	// get the current validator to eventually overwrite description and add opAddr
+	validatorStore, valFound := k.GetValidator(ctx, valAddr)
+	if valFound {
 		validator.Description = validatorStore.Description
 		validator = validatorStore.AddValidatorOperatorAddress(opAddr)
 	}
@@ -35,5 +36,16 @@ func (k msgServer) AddValidatorOperatorAddress(
 		ValidatorAddress: valAddr,
 	})
 
-	return &types.MsgAddValidatorOperatorAddressResponse{}, nil
+	var err error
+	if valFound {
+		err = ctx.EventManager().EmitTypedEvent(
+			&types.EventValidatorUpdated{
+				Validator: validator})
+	} else {
+		err = ctx.EventManager().EmitTypedEvent(
+			&types.EventValidatorCreated{
+				Validator: validator})
+	}
+
+	return &types.MsgAddValidatorOperatorAddressResponse{}, err
 }
diff --git a/x/profile/keeper/msg_create_coordinator.go b/x/profile/keeper/msg_create_coordinator.go
@@ -17,11 +17,11 @@ func (k msgServer) CreateCoordinator(
 	ctx := sdk.UnwrapSDKContext(goCtx)
 
 	// Check if the coordinator address is already in the store
-	coord, found := k.getCoordinatorByAddress(ctx, msg.Address)
+	coordByAddr, found := k.getCoordinatorByAddress(ctx, msg.Address)
 	if found {
 		return &types.MsgCreateCoordinatorResponse{},
 			sdkerrors.Wrap(types.ErrCoordAlreadyExist,
-				fmt.Sprintf("coordinatorId: %d", coord.CoordinatorID))
+				fmt.Sprintf("coordinatorId: %d", coordByAddr.CoordinatorID))
 	}
 
 	coordID := k.AppendCoordinator(ctx, types.Coordinator{
@@ -34,7 +34,12 @@ func (k msgServer) CreateCoordinator(
 		CoordinatorID: coordID,
 	})
 
+	coord, _ := k.GetCoordinator(ctx, coordID)
+	err := ctx.EventManager().EmitTypedEvent(
+		&types.EventCoordinatorCreated{
+			Coordinator: coord})
+
 	return &types.MsgCreateCoordinatorResponse{
 		CoordinatorID: coordID,
-	}, nil
+	}, err
 }
diff --git a/x/profile/keeper/msg_disable_coordinator.go b/x/profile/keeper/msg_disable_coordinator.go
@@ -41,8 +41,11 @@ func (k msgServer) DisableCoordinator(
 	coord.Active = false
 	k.SetCoordinator(ctx, coord)
 	k.RemoveCoordinatorByAddress(ctx, msg.Address)
+	err := ctx.EventManager().EmitTypedEvent(
+		&types.EventCoordinatorUpdated{
+			Coordinator: coord})
 
 	return &types.MsgDisableCoordinatorResponse{
 		CoordinatorID: coord.CoordinatorID,
-	}, nil
+	}, err
 }
diff --git a/x/profile/keeper/msg_update_coordinator_address.go b/x/profile/keeper/msg_update_coordinator_address.go
@@ -54,6 +54,9 @@ func (k msgServer) UpdateCoordinatorAddress(
 		CoordinatorID: coord.CoordinatorID,
 	})
 	k.SetCoordinator(ctx, coord)
+	err := ctx.EventManager().EmitTypedEvent(
+		&types.EventCoordinatorUpdated{
+			Coordinator: coord})
 
-	return &types.MsgUpdateCoordinatorAddressResponse{}, nil
+	return &types.MsgUpdateCoordinatorAddressResponse{}, err
 }
diff --git a/x/profile/keeper/msg_update_coordinator_description.go b/x/profile/keeper/msg_update_coordinator_description.go
@@ -48,5 +48,9 @@ func (k msgServer) UpdateCoordinatorDescription(
 	}
 
 	k.SetCoordinator(ctx, coord)
-	return &types.MsgUpdateCoordinatorDescriptionResponse{}, nil
+	err := ctx.EventManager().EmitTypedEvent(
+		&types.EventCoordinatorUpdated{
+			Coordinator: coord})
+
+	return &types.MsgUpdateCoordinatorDescriptionResponse{}, err
 }
diff --git a/x/profile/keeper/msg_update_validator_description.go b/x/profile/keeper/msg_update_validator_description.go
@@ -15,8 +15,8 @@ func (k msgServer) UpdateValidatorDescription(
 	ctx := sdk.UnwrapSDKContext(goCtx)
 
 	// Check if the validator address is already in the store
-	validator, found := k.GetValidator(ctx, msg.Address)
-	if !found {
+	validator, valfound := k.GetValidator(ctx, msg.Address)
+	if !valfound {
 		validator = types.Validator{
 			Address:     msg.Address,
 			Description: types.ValidatorDescription{},
@@ -40,6 +40,16 @@ func (k msgServer) UpdateValidatorDescription(
 	}
 
 	k.SetValidator(ctx, validator)
+	var err error
+	if valfound {
+		err = ctx.EventManager().EmitTypedEvent(
+			&types.EventValidatorUpdated{
+				Validator: validator})
+	} else {
+		err = ctx.EventManager().EmitTypedEvent(
+			&types.EventValidatorCreated{
+				Validator: validator})
+	}
 
-	return &types.MsgUpdateValidatorDescriptionResponse{}, nil
+	return &types.MsgUpdateValidatorDescriptionResponse{}, err
 }