Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Peer with no connection #813

Closed
lumtis opened this issue May 25, 2022 · 0 comments · Fixed by #822
Closed

Support Peer with no connection #813

lumtis opened this issue May 25, 2022 · 0 comments · Fixed by #822
Assignees
Labels
launch Related to launch module
Milestone

Comments

@lumtis
Copy link
Contributor

lumtis commented May 25, 2022

Is your feature request related to a problem? Please describe.
Support validator peer with no connection for ignite/cli#2220

Describe the solution you'd like

Adding none or a similar name in Peer

message Peer {
  string id = 1;

  oneof connection {
    string tcpAddress = 2;
    HTTPTunnel httpTunnel = 3;
    [EMPTY] none = 4; // empty struct
  }

  message HTTPTunnel {
    string name = 1;
    string address = 2;
  }
}

We still require to provide node ID which may not have practical usage for the launch

Describe alternatives you've considered

Allowing zero value for Peer. On the client, if id == "" the validator has no exposed peer

@lumtis lumtis added the launch Related to launch module label May 25, 2022
@lumtis lumtis added this to the Milestone B milestone May 26, 2022
@ivanovpetr ivanovpetr linked a pull request May 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launch Related to launch module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants