-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement peer empty connection #822
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #822 +/- ##
===========================================
- Coverage 10.51% 10.50% -0.02%
===========================================
Files 332 332
Lines 77548 77711 +163
===========================================
+ Hits 8157 8164 +7
- Misses 69185 69342 +157
+ Partials 206 205 -1
|
I'm trying to figure out if the NodeID, The node always has a node ID in the P2P network even if the public address is not exposed. But potentially this information is not necessary on-chain |
Good point, any updates on this? In such case we don't need this PR, we can just NOT set the |
We let it for now as the Node ID is a general information |
Co-authored-by: Alex Johnson <alex.johnson@tendermint.com>
No description provided.