feat: bump cosmos-sdk to v0.47.1
#1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
force-pushed
the
feat/update-sdk
branch
from
db54211 to
04dccd0
Compare
# Conflicts: # app/app.go # testutil/keeper/initializer.go # testutil/keeper/keeper.go # testutil/keeper/monitoring_provider.go # x/project/module.go # x/project/module_simulation.go # x/project/simulation/simulation.go
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 71.43% 71.35% -0.08%
==========================================
Files 218 218
Lines 9475 9471 -4
==========================================
- Hits 6768 6758 -10
- Misses 2535 2540 +5
- Partials 172 173 +1
|
jeronimoalbi
previously approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Great work @Pantani!
I left a couple of comments but otherwise LGTM 👍
One thing to comment is that cli-plugin-network must also be updated otherwise Ignite's "network" command won't work with the updated SPN.
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
the plugin will be the last one |
jeronimoalbi
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #. in case of a bug fix, this should point to a bug or any other related issue(s)
What does this PR do?
How to test?
Checklist
These are the criteria that every PR should meet, please check them off as you
review them: