feat(app): add monitoringp module
#721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
fadeev,
ilgooz,
lumtis,
Pantani,
ivanovpetr and
giunatale
as code owners
added 2 commits
April 13, 2022 11:03
Codecov Report
@@ Coverage Diff @@
## develop #721 +/- ##
========================================
Coverage 11.19% 11.19%
========================================
Files 278 278
Lines 60780 60780
========================================
+ Hits 6804 6805 +1
+ Misses 53792 53791 -1
Partials 184 184
|
giunatale
previously approved these changes
Apr 13, 2022
Technically, block heights can't even be 0. 1 is the minimum. We also have parameter validation checking if the |
Yes you're right, 1 will do nothing as well |
|
Let me just some time for the review, I will have to test the incentivized testnet workflow |
lumtis
reviewed
Apr 13, 2022
lumtis
previously approved these changes
Apr 14, 2022
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
|
failure in simtests seem to be related to #725 |
lumtis
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #715
lastBlockHeightto 1 instead of 0. This still disables anymonitoringpmodule actions