Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profile): ensure addresses are not equal for MsgAddValidatorOperatorAddress sim #727

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Apr 14, 2022

Closes #725

What does this PR does?

  • Add check to ensure that sim addresses are not the same

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #727 (21f3ba8) into develop (80ea112) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #727      +/-   ##
===========================================
- Coverage    11.20%   11.20%   -0.01%     
===========================================
  Files          278      278              
  Lines        60785    60787       +2     
===========================================
  Hits          6809     6809              
- Misses       53791    53793       +2     
  Partials       185      185              
Impacted Files Coverage Δ
x/profile/simulation/simulation.go 0.00% <0.00%> (ø)

@giunatale
Copy link
Contributor

question: should the ValidatorOperatorAddress not be a user (e.g. spn1...) address but rather a valoper (e.g. spnvaloper1...) address?

@lumtis
Copy link
Contributor

lumtis commented Apr 15, 2022

question: should the ValidatorOperatorAddress not be a user (e.g. spn1...) address but rather a valoper (e.g. spnvaloper1...) address?

We use spn prefix for simplicity since the message to add this address must contact a AccAddress to check signature. The xxvaloper.. format is what you will have on the testnet, the address is converted when the monitoring IBC packet is received

@lumtis lumtis merged commit 0726841 into develop Apr 15, 2022
@lumtis lumtis deleted the fix/val-op-addr-sim branch April 15, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulate MsgAddValidatorOperatorAddress sometimes fail
3 participants