test(monitoringp): increase code coverage
#736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
fadeev,
ilgooz,
lumtis,
Pantani,
ivanovpetr and
giunatale
as code owners
aljo242
changed the title
monitoringp) increase code coveragemonitoringp): increase code coverage
Codecov Report
@@ Coverage Diff @@
## develop #736 +/- ##
===========================================
+ Coverage 11.35% 11.43% +0.08%
===========================================
Files 278 278
Lines 60780 60780
===========================================
+ Hits 6899 6950 +51
+ Misses 53715 53666 -49
+ Partials 166 164 -2
|
lumtis
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
👍
I think we can create another issue to address monitoring_packet.go and TransmitSignatures where the packet is actually transmitted and that will require mocking TransmitMonitoringPacket method so we can close #687 after this current issue and coverage for monitoringc
giunatale
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #687
What does this PR does?
Increase code coverage for
x/monitoringp