fix(campaign): return correct request number in campaign summary
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
fadeev,
ilgooz,
Pantani,
ivanovpetr,
aljo242 and
giunatale
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #748 +/- ##
========================================
Coverage 11.40% 11.40%
========================================
Files 280 280
Lines 61476 61486 +10
========================================
+ Hits 7011 7014 +3
- Misses 54301 54309 +8
+ Partials 164 163 -1
|
giunatale
approved these changes
Apr 27, 2022
aljo242
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a method
GetRequestCountto get the number of requests instead of relying on the request counter that is used for determining the request IDThis count method iterates elements, in the store eventually we want to optimize this logic by adding a new entry in the store