Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(launch): update events format #758

Merged
merged 5 commits into from
May 5, 2022
Merged

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented May 3, 2022

Change some event attributes to allow performing filtering in queries. Like validator address in EventValidatorAdded

Might be able to address #755

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #758 (29cdab9) into develop (096ed50) will decrease coverage by 0.05%.
The diff coverage is 3.32%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #758      +/-   ##
===========================================
- Coverage    11.16%   11.10%   -0.06%     
===========================================
  Files          281      281              
  Lines        63642    64084     +442     
===========================================
+ Hits          7103     7115      +12     
- Misses       56376    56805     +429     
- Partials       163      164       +1     
Impacted Files Coverage Δ
x/launch/types/events.pb.go 0.51% <0.00%> (-0.11%) ⬇️
x/launch/keeper/chain.go 97.36% <100.00%> (+0.02%) ⬆️
x/launch/keeper/msg_request_add_account.go 100.00% <100.00%> (ø)
x/launch/keeper/msg_request_add_validator.go 100.00% <100.00%> (ø)
x/launch/keeper/msg_request_add_vesting_account.go 100.00% <100.00%> (ø)
x/launch/keeper/msg_request_remove_account.go 100.00% <100.00%> (ø)
x/launch/keeper/msg_request_remove_validator.go 100.00% <100.00%> (ø)
x/launch/keeper/request.go 95.07% <100.00%> (+0.20%) ⬆️
x/campaign/simulation/store.go 83.10% <0.00%> (-1.36%) ⬇️

giunatale
giunatale previously approved these changes May 4, 2022
@lumtis
Copy link
Contributor Author

lumtis commented May 5, 2022

UPDATE: Added campaignID for EventValidatorRemoved

@lumtis lumtis merged commit 8a86570 into develop May 5, 2022
@lumtis lumtis deleted the refactor/events-launch branch May 5, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants