Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(campaign): add tests for CampaignSummary #766

Merged
merged 4 commits into from
May 6, 2022

Conversation

giunatale
Copy link
Contributor

Closes #650

also fixes a misconfigured flags for a query in the CLI

I paid particular attention to keep code coverage as high as possible

@giunatale giunatale changed the title test(campaign): add test for CampaignSummary test(campaign): add tests for CampaignSummary May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #766 (f114dae) into develop (67ab845) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #766      +/-   ##
===========================================
+ Coverage    11.08%   11.27%   +0.18%     
===========================================
  Files          281      281              
  Lines        64148    64146       -2     
===========================================
+ Hits          7114     7233     +119     
+ Misses       56870    56742     -128     
- Partials       164      171       +7     
Impacted Files Coverage Δ
x/campaign/client/cli/query_campaign_summary.go 78.18% <100.00%> (+78.18%) ⬆️
x/campaign/keeper/grpc_campaign_summary.go 89.41% <100.00%> (+89.41%) ⬆️

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@giunatale giunatale requested a review from lumtis May 6, 2022 11:25
@lumtis lumtis merged commit ff51a17 into develop May 6, 2022
@lumtis lumtis deleted the test/campaign-summaries branch May 6, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add necessary tests for CampaignSummaries
3 participants