Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(campaign): create special allocations type #786

Merged
merged 16 commits into from
May 16, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented May 10, 2022

Implementing special allocations structure and add it to campaign

  • Type SpecialAllocations
  • Add tests for type
  • Add empty by default special allocations to campaign
  • Update CampaignShares invariant to include special allocations

@lumtis lumtis linked an issue May 10, 2022 that may be closed by this pull request
@lumtis lumtis changed the title feat(campaign): add special allocations feat(campaign): create special allocations type May 10, 2022
@lumtis lumtis marked this pull request as draft May 10, 2022 16:22
@lumtis lumtis marked this pull request as ready for review May 10, 2022 19:22
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #786 (bb43e03) into develop (e1cca3e) will increase coverage by 0.05%.
The diff coverage is 7.06%.

❗ Current head bb43e03 differs from pull request most recent head 99d49b2. Consider uploading reports for the commit 99d49b2 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #786      +/-   ##
===========================================
+ Coverage    10.58%   10.63%   +0.05%     
===========================================
  Files          313      304       -9     
  Lines        73081    72563     -518     
===========================================
- Hits          7736     7719      -17     
+ Misses       65158    64659     -499     
+ Partials       187      185       -2     
Impacted Files Coverage Δ
x/campaign/types/campaign.pb.go 0.51% <0.00%> (-0.05%) ⬇️
x/campaign/types/special_allocations.pb.go 1.40% <1.40%> (ø)
x/campaign/types/campaign.go 100.00% <100.00%> (ø)
x/campaign/types/special_allocations.go 100.00% <100.00%> (ø)
x/claim/types/params.go
x/claim/genesis.go
x/claim/types/genesis.pb.go
x/claim/types/tx.pb.go
x/claim/types/query.pb.gw.go
x/claim/keeper/params.go
... and 7 more

@lumtis lumtis requested a review from aljo242 May 11, 2022 18:19
giunatale
giunatale previously approved these changes May 13, 2022
Copy link
Contributor

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pre-approving, pending answer to my question above. Ping me if I need to re-review this

@giunatale giunatale self-requested a review May 13, 2022 11:59
@giunatale
Copy link
Contributor

Unit tests are failing, it's not due to the usual port-binding issue.

@lumtis
Copy link
Contributor Author

lumtis commented May 16, 2022

Simulation tests failing now with something we never had🤔

@aljo242
Copy link
Contributor

aljo242 commented May 16, 2022

We can go ahead and merge once unit tests pass.

@lumtis lumtis merged commit 9e38ac7 into develop May 16, 2022
@lumtis lumtis deleted the special-allocations-init branch May 16, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the SpecialAllocations structure
3 participants