-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(claim
): genesis and types
#800
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #800 +/- ##
===========================================
- Coverage 10.56% 10.54% -0.02%
===========================================
Files 315 328 +13
Lines 73466 76534 +3068
===========================================
+ Hits 7760 8073 +313
- Misses 65519 68256 +2737
- Partials 187 205 +18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress on the module
We need to add Validate
method for ClaimRecord
and Mission
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Some comments on the test file
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've marked the tc := tc
as per #806 so we can remove them from the UI. I agree with your comments @lubtd
rest looks good!
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
Closes #783
What does this PR does?
claim
moduleClaimRecord
andMission
typesValidate
methods and tests