Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(claim): genesis and types #800

Merged
merged 39 commits into from
May 20, 2022
Merged

feat(claim): genesis and types #800

merged 39 commits into from
May 20, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented May 16, 2022

Closes #783

What does this PR does?

  • add genesis of claim module
  • create ClaimRecord and Mission types
  • add Validate methods and tests
  • minor lint and fix

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #800 (8b50d54) into develop (9e38ac7) will decrease coverage by 0.01%.
The diff coverage is 10.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #800      +/-   ##
===========================================
- Coverage    10.56%   10.54%   -0.02%     
===========================================
  Files          315      328      +13     
  Lines        73466    76534    +3068     
===========================================
+ Hits          7760     8073     +313     
- Misses       65519    68256    +2737     
- Partials       187      205      +18     
Impacted Files Coverage Δ
x/claim/types/genesis.pb.go 0.79% <0.00%> (-0.55%) ⬇️
x/claim/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/claim/types/query.pb.go 0.72% <0.82%> (-0.44%) ⬇️
x/claim/types/claim_record.pb.go 0.83% <0.83%> (ø)
x/claim/types/mission.pb.go 1.01% <1.01%> (ø)
x/claim/types/genesis.go 67.39% <61.53%> (-32.61%) ⬇️
x/claim/keeper/grpc_query_airdrop_supply.go 72.72% <72.72%> (ø)
x/claim/keeper/airdrop_supply.go 76.92% <76.92%> (ø)
x/claim/genesis.go 84.61% <77.77%> (-15.39%) ⬇️
x/claim/keeper/grpc_query_mission.go 80.64% <80.64%> (ø)
... and 13 more

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress on the module

We need to add Validate method for ClaimRecord and Mission

proto/claim/genesis.proto Outdated Show resolved Hide resolved
proto/claim/mission.proto Outdated Show resolved Hide resolved
proto/claim/mission.proto Outdated Show resolved Hide resolved
proto/claim/genesis.proto Outdated Show resolved Hide resolved
proto/claim/genesis.proto Outdated Show resolved Hide resolved
x/claim/types/genesis.go Outdated Show resolved Hide resolved
x/claim/types/genesis.go Outdated Show resolved Hide resolved
x/claim/types/genesis.go Outdated Show resolved Hide resolved
x/claim/types/genesis.go Outdated Show resolved Hide resolved
x/claim/types/genesis.go Outdated Show resolved Hide resolved
Alex Johnson and others added 11 commits May 17, 2022 12:00
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@aljo242 aljo242 requested a review from lumtis May 18, 2022 17:40
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Some comments on the test file

x/claim/types/claim_record.go Outdated Show resolved Hide resolved
x/claim/types/mission_test.go Outdated Show resolved Hide resolved
x/claim/types/mission_test.go Outdated Show resolved Hide resolved
x/claim/types/mission_test.go Outdated Show resolved Hide resolved
x/claim/types/mission_test.go Outdated Show resolved Hide resolved
x/claim/types/claim_record_test.go Show resolved Hide resolved
x/claim/types/claim_record_test.go Show resolved Hide resolved
Alex Johnson and others added 3 commits May 18, 2022 16:35
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Copy link
Contributor

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've marked the tc := tc as per #806 so we can remove them from the UI. I agree with your comments @lubtd

rest looks good!

x/claim/client/cli/query_airdrop_supply_test.go Outdated Show resolved Hide resolved
x/claim/client/cli/query_claim_record_test.go Outdated Show resolved Hide resolved
x/claim/client/cli/query_mission_test.go Outdated Show resolved Hide resolved
x/claim/types/claim_record_test.go Outdated Show resolved Hide resolved
lumtis and others added 5 commits May 20, 2022 14:36
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
@lumtis lumtis merged commit 72b3631 into develop May 20, 2022
@lumtis lumtis deleted the feat/claim-genesis branch May 20, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize claim genesis state
3 participants