Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mint): add DevelopmentFund to block rewards #839

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Conversation

giunatale
Copy link
Contributor

Closes #809

Currently rewards are sent to addresses in the weighted list directly, no locking/vesting mechanisms. Anything to be done around that is TBD, perhaps we might want to add an issue to track this?

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #839 (06fddec) into develop (f3f4098) will increase coverage by 0.01%.
The diff coverage is 16.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #839      +/-   ##
===========================================
+ Coverage    10.40%   10.41%   +0.01%     
===========================================
  Files          325      325              
  Lines        75688    76047     +359     
===========================================
+ Hits          7872     7917      +45     
- Misses       67628    67940     +312     
- Partials       188      190       +2     
Impacted Files Coverage Δ
x/mint/types/mint.pb.go 0.52% <0.35%> (-0.06%) ⬇️
x/mint/types/params.go 8.46% <12.50%> (-0.63%) ⬇️
x/mint/simulation/genesis.go 97.72% <100.00%> (+1.17%) ⬆️
x/mint/simulation/params.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 81.08% <0.00%> (-3.38%) ⬇️

@lumtis
Copy link
Contributor

lumtis commented Jun 8, 2022

Currently rewards are sent to addresses in the weighted list directly, no locking/vesting mechanisms. Anything to be done around that is TBD, perhaps we might want to add an issue to track this?

Yes, I created this one #840 if you have thoughts to share

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add some sample addresses in config.yml param for the module to try out the feature locally. Eventually reusing addresses we have in accounts section

DistributeMintedCoins is a sensitive component. We should introduce unit tests for it. Eventually creating a separate issue for it depending on the complexity.

x/mint/types/params.go Show resolved Hide resolved
x/mint/keeper/keeper.go Show resolved Hide resolved
x/mint/simulation/genesis_test.go Show resolved Hide resolved
x/mint/keeper/keeper.go Outdated Show resolved Hide resolved
x/mint/simulation/genesis.go Show resolved Hide resolved
x/mint/simulation/genesis.go Outdated Show resolved Hide resolved
x/mint/simulation/genesis_test.go Outdated Show resolved Hide resolved
x/mint/simulation/params.go Outdated Show resolved Hide resolved
x/mint/simulation/params.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@aljo242 aljo242 merged commit ee188db into develop Jun 20, 2022
@aljo242 aljo242 deleted the feat/mint-devfund branch June 20, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DevelopmentFund for block rewards
4 participants