-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mint
): add DevelopmentFund
to block rewards
#839
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #839 +/- ##
===========================================
+ Coverage 10.40% 10.41% +0.01%
===========================================
Files 325 325
Lines 75688 76047 +359
===========================================
+ Hits 7872 7917 +45
- Misses 67628 67940 +312
- Partials 188 190 +2
|
Yes, I created this one #840 if you have thoughts to share |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add some sample addresses in config.yml
param for the module to try out the feature locally. Eventually reusing addresses we have in accounts
section
DistributeMintedCoins
is a sensitive component. We should introduce unit tests for it. Eventually creating a separate issue for it depending on the complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Closes #809
Currently rewards are sent to addresses in the weighted list directly, no locking/vesting mechanisms. Anything to be done around that is TBD, perhaps we might want to add an issue to track this?