Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the cli version #865

Merged
merged 5 commits into from
Jun 24, 2022
Merged

chore: update the cli version #865

merged 5 commits into from
Jun 24, 2022

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jun 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #865 (80bdef8) into develop (521ce9d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #865      +/-   ##
===========================================
- Coverage    10.45%   10.45%   -0.01%     
===========================================
  Files          326      326              
  Lines        76273    76273              
===========================================
- Hits          7977     7972       -5     
- Misses       68108    68111       +3     
- Partials       188      190       +2     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 81.08% <0.00%> (-3.38%) ⬇️

@lumtis
Copy link
Contributor

lumtis commented Jun 10, 2022

Thanks for the PR🙏
Based on #827, we will have to use a new version of cli in develop that removes dependency with campaign's mainnet vesting options

@lumtis
Copy link
Contributor

lumtis commented Jun 10, 2022

Let's wait on ignite/cli#2549 being merged and then let's import latest cli

@aljo242
Copy link
Contributor

aljo242 commented Jun 14, 2022

Looks like ignite/cli#2549 was merged, so we can update the package to the latest version and merge.

@Pantani
Copy link
Collaborator Author

Pantani commented Jun 15, 2022

Looks like ignite-hq/cli#2549 was merged, so we can update the package to the latest version and merge.

maybe it's better to merge this one first and update everything into the CLI to generate a new version and update this PR

@aljo242
Copy link
Contributor

aljo242 commented Jun 16, 2022

Looks like ignite-hq/cli#2549 was merged, so we can update the package to the latest version and merge.

maybe it's better to merge this one first and update everything into the CLI to generate a new version and update this PR

Sounds good - I'll approve after we do that merge

@Pantani
Copy link
Collaborator Author

Pantani commented Jun 16, 2022

Sounds good - I'll approve after we do that merge

ignite/cli#2600

@lumtis
Copy link
Contributor

lumtis commented Jun 17, 2022

Seems there was an issue with the version on the CLI, let's keep it pending now

@lumtis
Copy link
Contributor

lumtis commented Jun 24, 2022

Updated dependency for cli with org updated

@lumtis lumtis merged commit 5b1c8a7 into develop Jun 24, 2022
@lumtis lumtis deleted the chore/update-cli branch June 24, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants